758707 - Account Provisioner checkboxes should be disabled while search in progress

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Go to File > New > Get a New Mail Account
2. Enter a name, and start the search

What happens?

While the search occurs, the checkboxes to choose providers are still enabled, meaning the user can toggle them. This has the added defect of *re-enabling* the search button, which allows the user to trigger a second search in parallel to the first.

What's expected?

The UI should be locked down (with the exception of closing the window) while the search is in progress. So we should disable those checkboxes.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

This patch relies on both the patches from bug 757823 and bug 758237 (in that order) being applied.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 627325 [details] [diff] [review]
Patch v1

ui-r=me.

>+++ b/mail/test/mozmill/newmailaccount/test-newmailaccount.js
>+  // Our slow search has started. We have kSearchMSeconds milliseconds before
>+  // the search completes. Plenty of time to check that the right things are
>+  // disabled.

Should we also check that they get re-enabled once the search completes?

r=me either way.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2 (carrying over r+/ui-r+ from bwinton)

Good call - added those tests.

We want this to ship Account Provisioner.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

comm-central: https://hg.mozilla.org/comm-central/rev/96cb37390f45

Comment 5

[Mike Conley (:mconley) (:⚙️)]

comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/697fe4fdcf2d

Comment 6

[Mike Conley (:mconley) (:⚙️)]

comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/08204ee681fe