Closed
Bug 758748
Opened 12 years ago
Closed 12 years ago
Cannot build in toolkit/xre any more!
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: ehsan.akhgari, Assigned: joey)
Details
Attachments
(1 file)
1.24 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
$ make -C obj-ff-dbg/toolkit/xre Makefile:230: *** Variable SOURCE_REPO does not contain a value. Stop. Gerv, has this been caused by your recent changes?
Assignee | ||
Comment 1•12 years ago
|
||
(In reply to Ehsan Akhgari [:ehsan] from comment #0) > $ make -C obj-ff-dbg/toolkit/xre > Makefile:230: *** Variable SOURCE_REPO does not contain a value. Stop. > > Gerv, has this been caused by your recent changes? Are you building within an hg sandbox ? The error will be reported if 'hg showconfig' cannot obtain a value for $SOURCE_REPO (~line 264 in toolkit/xre/Makefile.in)
Comment 2•12 years ago
|
||
Joey, didn't we decide the goal was *NOT* to break local devs with your changes there. And that if it did break local devs something was severely wrong and it needed redesign/backout?
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #2) > Joey, didn't we decide the goal was *NOT* to break local devs with your > changes there. > > And that if it did break local devs something was severely wrong and it > needed redesign/backout? Similar content but I think this check/patch pre-dates that discussion. Another bug is open for collecting revision control commands into a central include file and it was discussed there. This is easy enough to revert or make conditional for o-fficial builds.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → joey
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 627344 [details] [diff] [review] change SOURCE_REPO var check from error to warn. Chaser job for bug # 688061 Morph SOURCE_REPO variable test from error to warn so building within a non-hg sandbox will not force failure.
Attachment #627344 -
Flags: review?(khuey)
Attachment #627344 -
Flags: review?(khuey) → review+
Reporter | ||
Comment 6•12 years ago
|
||
(In reply to Joey Armstrong [:joey] from comment #1) > (In reply to Ehsan Akhgari [:ehsan] from comment #0) > > $ make -C obj-ff-dbg/toolkit/xre > > Makefile:230: *** Variable SOURCE_REPO does not contain a value. Stop. > > > > Gerv, has this been caused by your recent changes? > > Are you building within an hg sandbox ? The error will be reported if 'hg > showconfig' cannot obtain a value for $SOURCE_REPO (~line 264 in > toolkit/xre/Makefile.in) I don't know what an hg sandbox is. I use git, FWIW. :-)
He means an hg checkout. :-)
Reporter | ||
Comment 8•12 years ago
|
||
Well, then, no. hg is not involved at all in my build process.
Assignee | ||
Comment 9•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=f4c6d3d41a94
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/728450b22631
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•