758782 - makefiles: declare mkdir_deps targets .PRECIOUS

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Joey Armstrong [:joey]]

mkdir_deps generated dependencies will be considered an intermediate file and removed when used as a pre-requisite for a wildcard target.

Add ".PRECIOUS: %/.mkdir.done" within config/makefiles/autotargets.mk to inhibit the behavior.  Problem surfaced while compiling idl files { toolkit/components/alerts }.

libalerts_s.a may also suffer from a similar problem:
nsAlertsService.cpp
/usr/bin/ccache c++ -o nsAlertsService.o [...]
rm -f libalerts_s.a

Comment 2

[Joey Armstrong [:joey]]

Attachment: mkdir_deps dependencies should be .PRECIOUS

Comment 3

[Joey Armstrong [:joey]]

Comment on attachment 627370 [details] [diff] [review]
mkdir_deps dependencies should be .PRECIOUS

Flag directory creation deps as .PRECIOUS to inhibit removal when they are considered an "intermediate file".

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 627370 [details] [diff] [review]
mkdir_deps dependencies should be .PRECIOUS

Review of attachment 627370 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/makefiles/autotargets.mk
@@ +18,5 @@
>  MKDIR ?= mkdir -p
>  TOUCH ?= touch
>  
> +# Deps will be considered intermediate when used as a pre-requisite for
> +# wildcard targets.  Inhibit their removal, mkdir -p is a standlaone op.

typo in standalone

Comment 5

[Joey Armstrong [:joey]]

Attachment: mkdir_deps dependencies should be .PRECIOUS

Comment 6

[Joey Armstrong [:joey]]

Comment on attachment 628388 [details] [diff] [review]
mkdir_deps dependencies should be .PRECIOUS

r=glandium carried forward.

Fixed typo in 'standalone' spelling.

Comment 7

[Joey Armstrong [:joey]]

Try job: https://tbpl.mozilla.org/?tree=Try&rev=f47e7fde1a62

Comment 8

[Joey Armstrong [:joey]]

Inbound push: https://hg.mozilla.org/integration/mozilla-inbound/rev/2e755d7847ac

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2e755d7847ac