758799 - [Mac] remove mIsExpired from mozAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Hubert Figuiere [:hub]]

remove mExpired from mozAccessible

See https://bugzilla.mozilla.org/show_bug.cgi?id=758304#c5

Comment 1

[Hubert Figuiere [:hub]]

And at the same time check for mGeckoAccessible in the various places to avoid crash.

Comment 2

[Hubert Figuiere [:hub]]

Attachment: Check accessible expiry properly. r=

Comment 3

[Hubert Figuiere [:hub]]

Attachment: Check accessible expiry properly. r=

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 632489 [details] [diff] [review]
Check accessible expiry properly. r=

Review of attachment 632489 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/mac/mozAccessible.mm
@@ +561,5 @@
>  }
>  
>  - (BOOL)isEnabled
>  {
> +  return mGeckoAccessible && ((mGeckoAccessible->InteractiveState() & states::UNAVAILABLE) == 0);

I would habitually enclose this in ()'s but ok. I can't recall our agreed style on this.

Comment 5

[Hubert Figuiere [:hub]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/91e737d544c7

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/91e737d544c7