Closed
Bug 759017
Opened 12 years ago
Closed 12 years ago
whitelisted key events does not contain correct keyCode information
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: timdream, Assigned: vingtetun)
References
(Depends on 1 open bug)
Details
Attachments
(2 files)
864 bytes,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
1.08 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #757486 +++ STR in Gaia: 1. replace apps/system/index.html with https://gist.github.com/2817145 2. in Gecko, invalid forwardKeyToHomescreen in b2g/chrome/content/shell.js (add |return;| at line 194) 3. Tap on the black space, allowing the iframe to gain focus 4. Press some keys Expected: * Getting keyCode in dump() Actual result: * Getting keyCode = 0
Reporter | ||
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
That's a small typo.
Comment 2•12 years ago
|
||
This should be tested, if we can...
Comment 3•12 years ago
|
||
Comment on attachment 628714 [details] [diff] [review] Patch Review of attachment 628714 [details] [diff] [review]: ----------------------------------------------------------------- Thank you for fixing that :)
Attachment #628714 -
Flags: review?(mounir) → review+
Comment 4•12 years ago
|
||
(In reply to Justin Lebar [:jlebar] from comment #2) > This should be tested, if we can... Damn... this is actually tested but the test has an error :-/
Comment 5•12 years ago
|
||
Two stupid mistakes that happen to be in the code and the test checking the code... that's unfortunate :-/
Attachment #628725 -
Flags: review?(21)
Updated•12 years ago
|
Attachment #628725 -
Flags: review?(21) → review+
Updated•12 years ago
|
Flags: in-testsuite+
Target Milestone: --- → mozilla15
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f16847bdf086
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 7•12 years ago
|
||
And: https://hg.mozilla.org/mozilla-central/rev/a35f9c1fef54
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•