75906 - No UI for pref "Leaving a site that supports encryption"

Status: VERIFIED FIXED

(Core :: Security: PSM, defect, P2)

Description

[John Unruh]

1.) Edit > Prefs > Privacy/Security > SSL.
Note that there is no UI to set the pref "Leaving a site that supports 
encryption".

Comment 1

[John Unruh]

Milestone 2.0

Comment 2

[David P. Drinan]

-> p2

Comment 3

[Stephen Walker]

Attachment: patch

Comment 4

[Daniel Brooks [:db48x]]

nifty, r=db48x

Comment 5

[Stephen Walker]

cc'ing blake for sr=

Comment 6

[Blake Ross]

cc'ing mpt/cotter to take a look at the wording.

Comment 7

[Stephane Saux]

Mass reassigning target to 2.1

Comment 8

[Matthew T (active 1999-2002)]

Looks ok to me, except that `Redirection' should be `Redirecting'.

Comment 9

[Stephen Walker]

Attachment: updated patch; Redirection -> Redirecting

Comment 10

[David P. Drinan]

+<!ENTITY warn.insecurepost "Sending form data from an insecure page to an
insecure page">
+<!ENTITY warn.leavingsecure "Leaving a site that supports encryption">
+<!ENTITY warn.secureredirect "Redirecting from one secure site to another">
+<!ENTITY warn.secureredirecttoinsecure "Redirecting from a secure site to an
insecure site">


Use non-secure instead of insecure.

Fix that and r=ddrinan.

Comment 11

[Stephen Walker]

Attachment: updated patch; insecure -> non-secure

Comment 12

[Sean Cotter]

<!ENTITY warn.enteringsecure "Entering a site that supports encryption">
<!ENTITY warn.enteringweak "Entering a site that uses low-grade encryption">

+<!ENTITY warn.insecurepost "Sending form data from a non-secure page to a
non-secure page">
+<!ENTITY warn.leavingsecure "Leaving a site that supports encryption">
+<!ENTITY warn.secureredirect "Redirecting from one secure site to another">
+<!ENTITY warn.secureredirecttoinsecure "Redirecting from a secure site to a
non-secure site">

I believe it would be more consistent (and accurate) to avoid the word "secure"
altogether, and also to describe things in terms of "pages" rather than "sites."
This can be done as follows:

Loading a page that supports encryption
Loading a page that uses low-grade encryption
Sending form data from an unencrypted page to an unencrypted page
Leaving a page that supports encryption
Redirecting from one encrypted page to another
Redirecting from an encrypted page to an unencrypted page

The above changes would also be consistent with my proposed patch for bug 44042. 

Question: Is this patch destined for the trunk only, which I assume means PSM
2.1? If it's destined for the branch it will require changes in the UI
translations, something I thought was no longer possible. It will also require
changes to help, which is still (barely) possible for 2.0.

Comment 13

[Stephen Walker]

Attachment: updated patch; with sean's changes

Comment 14

[David P. Drinan]

r=ddrinan.

Comment 15

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 16

[Javier Delgadillo]

Patch checked in.

Comment 17

[John Unruh]

Verified fixed on the trunk.