Closed Bug 759063 Opened 12 years ago Closed 12 years ago

toolkit/xre Windows tests link to unneeded updatecommon lib

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
Makefile.in change was introduced by bug 307181, butAFAICS it's not needed there. Try run confirms that:

https://tbpl.mozilla.org/?tree=Try&rev=eac75d4f7ea4

(It causes problems with my mingw builds, that have updater disabled).
Attachment #627643 - Flags: review?(ehsan)
Comment on attachment 627643 [details] [diff] [review]
fix v1.0

Yeah, this used to be necessary at some point, and then I ripped out that code and did not remove this.  Thanks for the fix.
Attachment #627643 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/8ffcc3efc77e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: