759105 - stop console spamming by MSAA events

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 627698 [details] [diff] [review]
patch

Review of attachment 627698 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/Logging.h
@@ +20,5 @@
>  namespace mozilla {
>  namespace a11y {
>  namespace logging {
>  
>  enum EModules {

Why is this called EModules?

@@ +25,5 @@
>    eDocLoad = 1 << 0,
>    eDocCreate = 1 << 1,
>    eDocDestroy = 1 << 2,
> +  eDocLifeCycle = eDocLoad | eDocCreate | eDocDestroy,
> +  eMSAA = 1 << 3

Why not ePlatform?

Comment 2

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #1)

> >  enum EModules {
> 
> Why is this called EModules?

sort of different modules inside a11y

> > +  eMSAA = 1 << 3
> 
> Why not ePlatform?

fine with me

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

OK thanks (f=me).

Comment 4

[Trevor Saunders (:tbsaunde)]

Comment on attachment 627698 [details] [diff] [review]
patch

I'm not sure grouping all msaa things or platform things together is the right module / logging group break up, but I don't see what it hurts to do it this way and changing should be easy if we decide to at some point.

Comment 5

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #4)
> I'm not sure grouping all msaa things or platform things together is the
> right module / logging group break up, but I don't see what it hurts to do
> it this way and changing should be easy if we decide to at some point.

I have the same feeling

Comment 6

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc775f973994

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dc775f973994