Closed
Bug 759159
Opened 12 years ago
Closed 12 years ago
Use index_of instead of lsearch in templates
Categories
(Bugzilla :: Bugzilla-General, enhancement)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: selsky, Assigned: selsky)
References
Details
Attachments
(1 file)
|
2.12 KB,
patch
|
LpSolit
:
review-
|
Details | Diff | Splinter Review |
Bug 560009 comment 3 suggested using index_of instead of lsearch in templates for clarity.
Attachment #627752 -
Flags: review?(LpSolit)
|
||
Comment 1•12 years ago
|
||
I'm not really happy to potentially break existing extensions which may use it because we simply renamed a TT function. If we changed its behavior at the same time, then why not, but here it's not the case. I agree that index_of() is much better than lsearch(), but lsearch() exists since Bugzilla 1.0! On the other hand, I don't know if this function is used a lot or not.
Severity: normal → enhancement
|
Assignee | |
Comment 2•12 years ago
|
||
Should I leave lsearch as an alias for index_of for compatibility?
|
|
||
Comment 3•12 years ago
|
||
There is a clear consensus on IRC to not break extensions, so we won't rename this function.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → WONTFIX
|
|
||
Updated•12 years ago
|
Attachment #627752 -
Flags: review?(LpSolit) → review-
You need to log in
before you can comment on or make changes to this bug.
Description
•