759169 - RenderTrace.cpp doesn't compile when MOZ_RENDERTRACE is enabled

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Dave Hylands [:dhylands]]

If I try to enable MOZ_RENDERTRACE by uncommenting the line in gfx/layers/RenderTrace.h, then I get the following errors:

/home/work/B2G/gecko/gfx/layers/RenderTrace.cpp: In function 'gfx3DMatrix mozilla::layers::GetRootTransform(mozilla::layers::Layer*)':
/home/work/B2G/gecko/gfx/layers/RenderTrace.cpp:19: error: passing 'const gfx3DMatrix' as 'this' argument of 'gfx3DMatrix& gfx3DMatrix::ProjectTo2D()' discards qualifiers
/home/work/B2G/gecko/gfx/layers/RenderTrace.cpp: In function 'void mozilla::layers::RenderTraceLayers(mozilla::layers::Layer*, const char*, gfx3DMatrix, bool)':
/home/work/B2G/gecko/gfx/layers/RenderTrace.cpp:30: error: passing 'const gfx3DMatrix' as 'this' argument of 'gfx3DMatrix& gfx3DMatrix::ProjectTo2D()' discards qualifiers

which occurs because ProjectTo2D modifies its matrix, but GetTransform returns a const ref.

Comment 1

[Benoit Girard (:BenWa)]

You just need to copy it first then it will work. Would be nice if you posted a patch.

Comment 2

[Dave Hylands [:dhylands]]

Attachment: Fix for compile error when MOZ_RENDERTRACE is enabled.

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 627793 [details] [diff] [review]
Fix for compile error when MOZ_RENDERTRACE is enabled.

Drive-by review. LGTM

Comment 4

[Benoit Girard (:BenWa)]

It was on my hg outgoing but I forgot to push it:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b48fd5b2b84e

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b48fd5b2b84e