Closed Bug 759282 Opened 12 years ago Closed 12 years ago

Location bar should have the same horizontal spacing between the icon and text as the autocomplete popup

Categories

(Firefox :: Theme, defect)

All
Windows XP
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 15

People

(Reporter: dao, Assigned: dao)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Currently, the text in the location bar is indented slightly more than in the autocomplete popup.
Attachment #627908 - Flags: review?(jaws)
Comment on attachment 627908 [details] [diff] [review]
patch

This doesn't fix it when the back button isn't connected to the location bar. Needs more adjustments to work consistently.
Attachment #627908 - Flags: review?(jaws)
Attached patch patch v2Splinter Review
Attachment #627908 - Attachment is obsolete: true
Attachment #628279 - Flags: review?(jaws)
Comment on attachment 628279 [details] [diff] [review]
patch v2

Are you planning on fixing this for pinstripe and gnomestripe? Or do those themes not have this same issue?
Attachment #628279 - Flags: review?(jaws) → review+
gnomestripe doesn't have it, I haven't checked pinstripe.
I can check on pinstripe today.
(In reply to Jared Wein [:jaws] from comment #5)
> I can check on pinstripe today.

Thanks. I'll land this now. Please clone this bug for OS X if needed.
http://hg.mozilla.org/integration/mozilla-inbound/rev/be6973c48222
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/be6973c48222
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: