75934 - Display dot in window close widget of windows with unsaved contents

Status: NEW

(Core :: XUL, enhancement)

Description

[Henri Sivonen (:hsivonen)]

On Mac OS X, the window close button is supposed to have a dot in the middle, if
the window contains unsaved changes. Editor windows don't support this.

See page 55 of the Aqua HIG (Macworld draft).

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Actual results

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Expected results (when there are unsaved changes)

Comment 3

[Simon Fraser [no longer active]]

We need to use the SetWindowModified API, or whatever it's called, and should 
probably have generic hooks for this. nsIDiskDocument would be a good place at 
the lower level, but this would need to communicate up to the widget layer 
somehow. This is kinda similar to the window icon problem.

Comment 4

[Andrew Thompson]

I was looking at this for some of the window icon stuff and editor at least has
an api where you can attach listeners to the ?document? who can observe whether
its dirty or not. However since presumably mail compose windows want to do this
too, it should be done at a lower level than editor.

Henri, did you intend this bug to apply to more than the editor? ie, will you
make another one for mailnews?

Comment 5

[Kathleen :Brade]

Why wouldn't mail compose windows also want this behavior?  Wouldn't users want 
to know if the draft had been saved or not?  I think this bug should cover both 
Composer and Mail Compose.

Comment 6

[Henri Sivonen (:hsivonen)]

I haven't been testing Mail&News, but this probably applies to more than just
the Editor.

Comment 7

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 8

[Simon Fraser [no longer active]]

Pre-sabbatical bug triage.

Comment 9

[Greg K.]

Revising summary.

Comment 10

[zug_treno]

*** Bug 317813 has been marked as a duplicate of this bug. ***

Comment 11

[Wayne Mery (:wsmwk)]

see also bug 370318

Comment 13

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Now works in BlueGriffon ; see

http://sources.disruptive-innovations.com/bluegriffon/trunk/src/diOSXDockIconBadger/

and |<method name="updateOSXCloseButton">| in
http://sources.disruptive-innovations.com/bluegriffon/trunk/base/content/bluegriffon/bindings/tabeditor.xml

Comment 14

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

ehsan just made me the owner of this bug... Hey, ehsan, ask me next time ?
Ok, I'll try to make a patch for composer here.

Comment 15

[(no longer active)]

(In reply to comment #14)
> ehsan just made me the owner of this bug... Hey, ehsan, ask me next time ?

I didn't actually!  You just seem to be the default assignee for this component (probably dating back to several years ago)!  Please file a bug to get that fixed.  :-)

Sorry for the confusion.  ;-)

Comment 16

[[e-mail]]

(In reply to comment #15)
> (In reply to comment #14)
> > ehsan just made me the owner of this bug... Hey, ehsan, ask me next time ?
> I didn't actually!  You just seem to be the default assignee for this component
I don't think composer is the right component for this anyway, it seems like something that should be fixed using either an attribute on the <window> or a property on nsIChromeWindow or maybe nsIXULWindow.

At some point web pages (e.g. webmail) might want to be able to notify the chrome as to whether they have unsaved changes too, and chrome could then set the dot if any of the tabs has unsaved changes.

Comment 17

[(no longer active)]

OK, moving over to XUL then.