Closed Bug 759354 Opened 12 years ago Closed 12 years ago

Add other device sensors to nsEventListenerManager::IsDeviceType

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

patch v.1
786 bytes, patch
smaug
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsEventListenerManager.cpp#299

If we do not, then these sensors will not turn off when the event listener is removed.
Assignee: nobody → doug.turner
Attached patch patch v.1 — — Splinter Review 

        Attachment #627979 -
        Flags: review?(bugs)

        Attachment #627979 -
        Flags: review?(bugs) → review+
Target Milestone: --- → mozilla16

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/afa7b85781dc
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 627979 [details] [diff] [review]
patch v.1

we need this or devices may not be shutdown after use.

        Attachment #627979 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 627979 [details] [diff] [review]
patch v.1

Approved for the same reason as https://bugzilla.mozilla.org/show_bug.cgi?id=742376#c23

        Attachment #627979 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: