Closed
Bug 759457
Opened 12 years ago
Closed 12 years ago
-moz-transform causes box-shadow quirks
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: cvan, Assigned: jrmuizel)
References
Details
(Keywords: regression)
Attachments
(4 files)
9.93 KB,
image/png
|
Details | |
10.55 KB,
image/png
|
Details | |
211 bytes,
text/html
|
Details | |
976 bytes,
patch
|
roc
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
User agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:15.0) Gecko/15.0 Firefox/15.0a1 Test case: http://jsfiddle.net/Wj64w/ Behaviour: `-moz-transform: scalex(-1)` causes `box-shadow` styles to get clipped.
Reporter | ||
Comment 1•12 years ago
|
||
Reporter | ||
Updated•12 years ago
|
Component: General → Layout
Product: Firefox → Core
QA Contact: general → layout
Reporter | ||
Updated•12 years ago
|
Version: unspecified → 15 Branch
Reporter | ||
Comment 2•12 years ago
|
||
Comment 3•12 years ago
|
||
This regressed at a changeset that landed between May 22 and May 28, inclusive.
Keywords: regression,
regressionwindow-wanted
Comment 4•12 years ago
|
||
This was caused by the landing of the patch in bug 757039. https://hg.mozilla.org/mozilla-central/rev/dc8bae2d72e7 If we back that out, we should consider backing that out of aurora too, since it got uplifted to that branch.
Keywords: regressionwindow-wanted
Comment 5•12 years ago
|
||
Ah, I misread the bug. It hasn't been uplifted to aurora yet. Scratch that last bit.
Assignee | ||
Comment 6•12 years ago
|
||
This should fix it
Assignee: nobody → jmuizelaar
Attachment #628215 -
Flags: review?(roc)
Attachment #628215 -
Flags: review?(roc) → review+
Comment 7•12 years ago
|
||
jrmuizel and roc, thanks for the quick fix and review! :)
Assignee | ||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b480a66acbc
Assignee | ||
Comment 9•12 years ago
|
||
Comment on attachment 628215 [details] [diff] [review] Don't fast path negative scales [Approval Request Comment] Bug caused by (feature/regressing bug #): 757039 User impact if declined: Buggy shadow drawing with css transforms Testing completed (on m-c, etc.): This is basically a partial revert of 757039 Risk to taking this patch (and alternatives if risky): Reduces the risk of taking 757039 because the new code is triggered in fewer cases. String or UUID changes made by this patch:
Attachment #628215 -
Flags: approval-mozilla-aurora?
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6b480a66acbc
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Comment 11•12 years ago
|
||
Comment on attachment 628215 [details] [diff] [review] Don't fast path negative scales [Triage Comment] Approved for Aurora 14. If this doesn't land in time for the merge this afternoon PT, please re-nominate for Beta approval.
Attachment #628215 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 12•12 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/57b91ddc54fc
Assignee | ||
Updated•12 years ago
|
status-firefox14:
--- → fixed
Updated•12 years ago
|
status-firefox15:
--- → fixed
Comment 13•12 years ago
|
||
Hi guys. I wanted to verify this bug and so I compared the test case between Firefox 15 beta 1 and Firefox 13 beta 6 and they are exactly the same. Since is fixed in FX14 and 15, shouldn't the image be different in Firefox 13? Thanks
Assignee | ||
Comment 14•12 years ago
|
||
(In reply to Vlad [QA] from comment #13) > Hi guys. > I wanted to verify this bug and so I compared the test case between Firefox > 15 beta 1 and Firefox 13 beta 6 and they are exactly the same. > Since is fixed in FX14 and 15, shouldn't the image be different in Firefox > 13? > > Thanks This was never released broken. It was broken and fixed before a release.
Comment 15•12 years ago
|
||
Considering comment 13 and 14, changing the flags to verified.
You need to log in
before you can comment on or make changes to this bug.
Description
•