759521 - WebTelephony: investigate test failures for outgoing calls

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

Some of the outgoing call tests in bug 756607 fail and had to be disabled. We should investigate if they're testing faulty assumptions, our implementation is busted, or the emulator is messing things up somehow.

Comment 1

[Dietrich Ayala (:dietrich)]

Not a blocker - a test harness problem.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

After discussing with Price about the error-notifying mechanism and some experiments, "error" event is never fired in the situation of dialing a bad number. That's the reason why "test_outgoing_badNumber.js" in bug 756607 always fails. 

Actually, the events of dialing a bad number are the same as those of dialing a legal number.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Regarding the failure in "test_outgoing_busy.js" there are two reasons: 
(1) WebTelephony never fires "busy" event because the call state never reaches nsIRadioInterfaceLayer::CALL_STATE_BUSY in our implementation. 
(2) the emulator command "gsm busy" can be used only if the current call state is "waiting". In the test script, the call state right before "gsm busy" is unknown.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch: update test_outgoing_reject.js

"gsm cancel" cannot be used to cancel a call with unknown state. We need to wait until the connection is established, then "gsm cancel" works fine.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #3)
> Regarding the failure in "test_outgoing_busy.js" there are two reasons: 
> (1) WebTelephony never fires "busy" event because the call state never
> reaches nsIRadioInterfaceLayer::CALL_STATE_BUSY in our implementation. 

I filed Bug 761533 for this failure.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch (v2) : update test_outgoing_reject.js

addressed some nits

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch (v3): update test scripts

Minor modifications are applied according to the investigation in bug 757587. Thanks.

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch (v4)

Updated.

When I was working on bug 761533, I found that we might miss something for call error event. Seems nothing incorrect in Philipp's test script 'test_outgoing_basNumber.js' So, I added 'test_outgoing_basNumber.js', which had been deleted in attachment 631317 [details] [diff] [review], back. Thanks.

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

In Bug 761533, i will revisit call error handling function. So, I will keep investigate test_outgoing_badNumber and test_outgoing_busy there.

Comment 10

[Philipp von Weitershausen [:philikon]]

Comment on attachment 631341 [details] [diff] [review]
Patch (v4)

Review of attachment 631341 [details] [diff] [review]:
-----------------------------------------------------------------

Good sleuthing! r=me with readability nit addressed.

::: dom/telephony/test/marionette/test_outgoing_reject.js
@@ +75,5 @@
> +function waitForCancel() {
> +  runEmulatorCmd("gsm list", cmdCallback);
> +}
> +
> +function cmdCallback(result) {

Not sure why you didn't inline this... You don't refer to it anywhere else, so it just clutters up readability, I think.

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Philipp von Weitershausen [:philikon] from comment #10)
> Comment on attachment 631341 [details] [diff] [review]
> Patch (v4)
> 
> Review of attachment 631341 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Good sleuthing! r=me with readability nit addressed.
> 
> ::: dom/telephony/test/marionette/test_outgoing_reject.js
> @@ +75,5 @@
> > +function waitForCancel() {
> > +  runEmulatorCmd("gsm list", cmdCallback);
> > +}
> > +
> > +function cmdCallback(result) {
> 
> Not sure why you didn't inline this... You don't refer to it anywhere else,
> so it just clutters up readability, I think.
Thanks for the comment. Will provide a new patch with the comment addressed. :)

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch (v5)

addressed nit in Comment #10. Thanks!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a958b5ab2f48

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a958b5ab2f48