75996 - confirmCheck method of nsIPrompt interface doesnot work properly under certain condition.

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[dsirnapalli]

i used the below snippet of code in my javascript testcase.

var checkbox = {value:0};
var boo = promptObj.confirmCheck("confirmcheck dialog",
                                 "Do you want to continue",
                                 "check or uncheck",checkbox);
alert("Checkbox checked: " + checkbox.value);
alert("Confirmation accepted: " + boo);

when the confirm dialog came up i selected checkbox checked and pressed cancel.
the above alert Checkbox checked was showing true(should be false since you 
canceled).

Comment 1

[dsirnapalli]

-- Reassigned as per jud's suggestion.

Comment 2

[Conrad Carlen (not reading bugmail)]

True. If the dialog is canceled, nothing should happen with the check value.

Comment 3

[Conrad Carlen (not reading bugmail)]

Attachment: patch so check value is not changed on cancel

Comment 4

[Conrad Carlen (not reading bugmail)]

Dan, can you review?

Comment 5

[Dan M]

Only if I get my inbox cleaned out and/or notice the request. Sorry for the 
delay. Sure, r=me. (PS -- the idl says the checkbox parameter in confirmCheck is 
"out", but the code treats it as "inout". Might want to update that as you did 
for confirmEx. Someday.)

Comment 6

[Conrad Carlen (not reading bugmail)]

> the idl says the checkbox parameter in confirmCheck is "out"
It should be inout. That was bug 75993 which is checked in.

CC'ing Alec for sr.  

Comment 7

[Alec Flett]

easy enough! sr=alecf

Comment 8

[Conrad Carlen (not reading bugmail)]

Fix checked in.

Comment 9

[dsirnapalli]

-- working as expected. marking bug as verified.