760289 - crash in nsPop3Sink::IncorporateAbort

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[Wayne Mery (:wsmwk)]

This bug was filed from the Socorro interface and is 
report bp-d40ab1fe-b09a-49c3-9b7c-9bb542120529 .
============================================================= 

0 	xul.dll 	nsPop3Sink::IncorporateAbort 	mailnews/local/src/nsPop3Sink.cpp:933
1 	xul.dll 	nsPop3Protocol::Abort 	mailnews/local/src/nsPop3Protocol.cpp:1026
2 	xul.dll 	nsPop3Protocol::Cancel 	mailnews/local/src/nsPop3Protocol.cpp:1037
3 	xul.dll 	nsLoadGroup::Cancel 	netwerk/base/src/nsLoadGroup.cpp:340
4 	xul.dll 	nsDocLoader::Stop 	uriloader/base/nsDocLoader.cpp:360
5 	xul.dll 	nsDocShell::Stop 	docshell/base/nsDocShell.cpp:4319
6 	xul.dll 	nsMsgWindow::StopUrls 	mailnews/base/src/nsMsgWindow.cpp:377
7 	xul.dll 	nsMsgWindow::CloseWindow 	mailnews/base/src/nsMsgWindow.cpp:145
8 	xul.dll 	NS_InvokeByIndex_P 	xpcom/reflect/xptcall/src/md/win32/xptcinvoke.cpp:102
9 	xul.dll 	XPCWrappedNative::CallMethod 	js/xpconnect/src/XPCWrappedNative.cpp:2198

Comment 1

[Wayne Mery (:wsmwk)]

bp-f27639ef-e115-4ec1-a596-ebde82130910 version 17
unable to contact any users

Comment 2

[Wayne Mery (:wsmwk)]

This exact stack quite rare - only one of 10 I examined for TB17.0.8.
bp-52f2bd1a-9525-4d3e-9ef2-dd67c2130920

most common is bp-62423165-8681-4880-bea7-eb02e2130914
0	xul.dll	nsPop3Sink::IncorporateAbort(bool)	mailnews/local/src/nsPop3Sink.cpp
1	xul.dll	nsPop3Protocol::ProcessProtocolState(nsIURI *,nsIInputStream *,unsigned int,unsigned int)	mailnews/local/src/nsPop3Protocol.cpp
2	xul.dll	nsPop3Protocol::OnStopRequest(nsIRequest *,nsISupports *,unsigned int)	mailnews/local/src/nsPop3Protocol.cpp
3	xul.dll	nsInputStreamPump::OnStateStop()	netwerk/base/src/nsInputStreamPump.cpp
4	xul.dll	nsInputStreamPump::OnInputStreamReady(nsIAsyncInputStream *)	netwerk/base/src/nsInputStreamPump.cpp 

No crashes so far for TB24

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: bug760289_crash_in_incorporate_abort.patch

Add same protections as in IncorporateComplete

Comment 4

[Wayne Mery (:wsmwk)]

TB24
bp-f852b0c9-6da1-41ec-a304-854be2131022
bp-4dda0d07-2d64-4bc8-a368-af8a32131103
but only two crashes in past month

Comment 5

[:Irving Reid (No longer working on Firefox)]

Comment on attachment 815792 [details] [diff] [review]
bug760289_crash_in_incorporate_abort.patch

Review of attachment 815792 [details] [diff] [review]:
-----------------------------------------------------------------

Based on the similar change in IncorporateComplete() this should be fine.

Comment 6

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/8f768cf18b43 -> FIXED