Closed
Bug 760311
Opened 12 years ago
Closed 12 years ago
content/html/content/test/forms/test_change_event.html ran additional tests after finish() was called
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
Attachments
(2 files)
2.14 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
12.27 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Fallout from the diagnostic patch in bug 677964.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #628944 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #628946 -
Flags: review?(bzbarsky)
Comment 3•12 years ago
|
||
Comment on attachment 628944 [details] [diff] [review] Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup(). r=me
Attachment #628944 -
Flags: review?(bzbarsky) → review+
Comment 4•12 years ago
|
||
Comment on attachment 628946 [details] [diff] [review] Fix DOS line endings. r=me
Attachment #628946 -
Flags: review?(bzbarsky) → review+
Comment 5•12 years ago
|
||
Comment on attachment 628944 [details] [diff] [review] Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup(). Review of attachment 628944 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/html/content/test/forms/test_change_event.html @@ -133,5 @@ > input.click(); > input.blur(); > is(NonTextInputChange[5], 1, "Change event shouldn't be dispatched for checkbox ---> text input type change"); > > - MockFilePicker.cleanup; Why did you remove that? AFAIK, it is necessary.
Attachment #628944 -
Flags: review-
Assignee | ||
Comment 6•12 years ago
|
||
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #5) > - MockFilePicker.cleanup; > Why did you remove that? AFAIK, it is necessary. I didn't remove it, I moved it closer to where it's used and changed it to MockFilePicker.cleanup(). It wasn't being called before.
Comment 7•12 years ago
|
||
Comment on attachment 628944 [details] [diff] [review] Add a setTimeout to workaround <input type=file> blur issues, and actually call MockFilePicker.cleanup(). Review of attachment 628944 [details] [diff] [review]: ----------------------------------------------------------------- Very sorry about that :(
Attachment #628944 -
Flags: review-
Assignee | ||
Comment 8•12 years ago
|
||
https://tbpl.mozilla.org/?usebuildbot=1&tree=Try&rev=5db9663b5473
Assignee | ||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c39ac876f64 https://hg.mozilla.org/integration/mozilla-inbound/rev/defd9a933da5
Target Milestone: --- → mozilla15
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/defd9a933da5 https://hg.mozilla.org/mozilla-central/rev/8c39ac876f64
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•