Closed Bug 760424 Opened 12 years ago Closed 12 years ago

browser_tab_dragdrop.js is buggy, doesn't remove the correct event listener

Categories

(Firefox :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

browser_tab_dragdrop.js tries to remove not-existing event listener, and
ends up handling load event from iframes although it doesn't expect it.

Patch coming.
Attached patch patchSplinter Review
Mats, I think you wrote the test long ago for bug 449734.
Attachment #629172 - Flags: review?(matspal)
Comment on attachment 629172 [details] [diff] [review]
patch

And the var c = 0; is a leftover from debugging. I'll remove it.
Comment on attachment 629172 [details] [diff] [review]
patch

Thanks.
Attachment #629172 - Flags: review?(matspal) → review+
https://hg.mozilla.org/mozilla-central/rev/def37b64a758
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Looks like browser_tab_dragdrop2.js has a similar issue:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/test/browser_tab_dragdrop2.js?rev=574b0fb35604#21
(added on window_B.gBrowser, removed on window_B)
which might explain bug 598294?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: