760463 - de-ns-ify nsBaseWidgetAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

I'd suggest to rename the file to general/BaseAccessibles in contrast to my suggestion in bug 759310 (ElementAccessibles). Sounds ok?

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

Renamed / moved files to generic/BaseAccessibles, renamed three classes, tweaked header guards, added to namespace, changed mozilla::a11y::role, tweaked include order, tweaked type*'s, blanks before ":" 's, removed couple whitespace nits ... blah blah blah :)

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 629525 [details] [diff] [review]
Patch (v1)

Review of attachment 629525 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/base/nsBaseWidgetAccessible.cpp
@@ +226,5 @@
>  ////////////////////////////////////////////////////////////////////////////////
>  
> +EnumRoleAccessible::
> +  EnumRoleAccessible(nsIContent* aNode, DocAccessible* aDoc,
> +                     roles::Role aRole) :

keep on the same line pls

::: accessible/src/base/nsBaseWidgetAccessible.h
@@ +95,4 @@
>  {
>  public:
> +  EnumRoleAccessible(nsIContent* aContent, DocAccessible* aDoc,
> +                     mozilla::a11y::role aRole);

a11y::role

::: accessible/src/xul/nsXULListboxAccessible.h
@@ +9,1 @@
>  #include "nsCOMPtr.h"

it doesn't seem you need nsCOMPtr.h include

::: accessible/src/xul/nsXULTabAccessible.h
@@ +6,5 @@
>  #ifndef _nsXULTabAccessible_H_
>  #define _nsXULTabAccessible_H_
>  
>  // NOTE: alphabetically ordered
> +#include "BaseAccessibles.h"

what's for?

Comment 3

[Mark Capella [:capella]]

https://tbpl.mozilla.org/?tree=Try&rev=11e7729cc708

Comment 4

[Mark Capella [:capella]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=19b3c7d978a9

Comment 5

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/mozilla-central/rev/0dd9a6f719e8