Closed Bug 76051 Opened 23 years ago Closed 23 years ago

Illegal implicit casts break CodeWarrior6

Categories

(SeaMonkey :: Build Config, defect, P3)

PowerPC
macOS
defect

Tracking

(Not tracked)

VERIFIED WONTFIX
mozilla1.0

People

(Reporter: lordpixel, Assigned: lordpixel)

References

Details

Attachments

(6 files)

CodeWarrior 6 can't build libreg.mcp due to an illegal implicit cast from (char *
*) to (void **). Why do I feel that I'm gonna find a few of these?

Patch will be attached shortly
Blocks: 53682
Generalised bug, not specific to libreg.

Interesting;y, CW6 seems to be applyng C++ rules to reg.c
Summary: Illegal implicit cast in libreg breaks CodeWarrior6 → Illegal implicit casts break CodeWarrior6
Are we sure there aren't some compiler options that might be a better way to fix
this? How about the "relaxed pointer type rules" option?
Priority: -- → P3
Target Milestone: --- → mozilla1.0
Um, well, 


* There are only 6 fixes to make in the whole tree.

* Why would we want to disable errors being generated from code which is illegal
according to the C++ spec (or so I'm told).

Obviously one of these errors at least is for a C file and is legal, but having
the casts made explicit actually serves to document what's happening in the code
more clearly, IMO.
BTW, the changes I made were purely to make it compile. If anyone can look at
them and say they're conceptually wrong and a better fix it needed, please pipe
up now!
This one looks suspicious to me:

-       aContext.GetDeviceContext(*getter_AddRefs(theDevContext));
+       aContext.GetDeviceContext((nsIDeviceContext *&)*
getter_AddRefs(theDevContext));

and there's a double cast here which looks wrong:

-  (nsIWidget*)(aEvent->widget)->GetClientData((PluginViewerImpl *)pluginViewer);
+  (nsIWidget*)(aEvent->widget)->GetClientData((void *&)(PluginViewerImpl *
)pluginViewer);

The rest looks good.
This should not be mine. Reassigning to lordpixel@mac.com since he's been doing
all the work
Assignee: jj → lordpixel
If this doesn't break CW7 let's close this as WONTIX

Well, I don't have 7 to check. Its possible that many of these have been fixed 
along the way in other bugs. Last time I asked somone said all of the CW7 builds 
are on a branch and no fixes have been checked into the trunk. Is this still 
true? If so, we won't know if all of them have been fixed. I don't know if its 
possible to build the trunk in CW 7?
ccarlen got a branch building on Pro7 and our target to land that on the trunk
is the end of October (2001 for you pessimists :-)  I'm gonna close this and
75333 as WONTFIX.  Sorry to throw away the work Andy but since we skipped Pro6
(and it may very well be that ccarlen used some of this for Pro7 so we're prlooy
not actually throwing it away...
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WONTFIX
verified wontfix.
no, really.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: