Closed
Bug 760643
Opened 12 years ago
Closed 12 years ago
Device Storage - Delete isn't working
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: dougt, Assigned: dougt)
Details
Attachments
(1 file)
9.52 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
Currently Delete() is silently failing. I am going to change the code to test for existence after delete and fire an onError if the file continues to exists. We are also incorrectly calculating the path of storage. I am going to clean up our DeviceStorageFile to always clone() the nsIFile to avoid such problems.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #629317 -
Flags: review?(jonas)
Comment on attachment 629317 [details] [diff] [review] patch v.1 Review of attachment 629317 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/devicestorage/nsDeviceStorage.cpp @@ +43,5 @@ > + nsCOMPtr<nsIFile> file; > + aFile->Clone(getter_AddRefs(mFile)); > + } > + nsCOMPtr<nsIFile> mFile; > + nsString mPath; Put these first or last. Keeping them in the middle makes them hard to find.
Attachment #629317 -
Flags: review?(jonas) → review+
Assignee | ||
Comment 3•12 years ago
|
||
last patch broke windows. fixed up the path, pushed to try, and its good now. results should be coming soon.
Assignee | ||
Comment 4•12 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=aaa30a35850f inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/efa54ecee724
Updated•12 years ago
|
Target Milestone: --- → mozilla16
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/efa54ecee724
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•