Closed
Bug 760732
Opened 12 years ago
Closed 12 years ago
Remove all gaiamobile.org prefs from b2g.js
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fabrice, Unassigned)
Details
Attachments
(1 file)
3.43 KB,
patch
|
vingtetun
:
review+
cjones
:
review+
|
Details | Diff | Splinter Review |
We now add all these prefs in user.js as part as the gaia build process, so let's remove all these hardcoded domains from b2g.js
Reporter | ||
Updated•12 years ago
|
Attachment #629387 -
Flags: review?(21)
Comment 1•12 years ago
|
||
What about the builds on the jsconf phones? Do we have a graceful upgrade path for them?
Comment 2•12 years ago
|
||
(In reply to Philipp von Weitershausen [:philikon] from comment #1) > What about the builds on the jsconf phones? Do we have a graceful upgrade > path for them? Nobody more than me wants to remove those prefs but the JSConf phones are going to be dead if this patch is pushed and Gecko is updated before Gaia. Let's see what @cjones thinks about it.
Comment 3•12 years ago
|
||
Comment on attachment 629387 [details] [diff] [review] patch I'm fine with the code removal fwit, just unsure about the decision to make here so I would like Chris review before landing that.
Attachment #629387 -
Flags: review?(jones.chris.g)
Attachment #629387 -
Flags: review?(21)
Attachment #629387 -
Flags: review+
Fabrice, how far away are we from being able to populate the permissions DB from app manifests at install time? (If you know.) I'm pretty loath to break JSConf phones. If we're far away from a "real" fix here, I would prefer to split this gunk out into another file and conditionally include it for now.
Reporter | ||
Comment 5•12 years ago
|
||
(In reply to Chris Jones [:cjones] [:warhammer] from comment #4) > Fabrice, how far away are we from being able to populate the permissions DB > from app manifests at install time? (If you know.) We haven't started on this yet. > I'm pretty loath to break JSConf phones. If we're far away from a "real" > fix here, I would prefer to split this gunk out into another file and > conditionally include it for now. ok, I'll see what we can do to not break jsconf phones.
Comment 6•12 years ago
|
||
(In reply to Fabrice Desré [:fabrice] from comment #5) > (In reply to Chris Jones [:cjones] [:warhammer] from comment #4) > > Fabrice, how far away are we from being able to populate the permissions DB > > from app manifests at install time? (If you know.) > > We haven't started on this yet. Do we already have a permissions DB and just the filling is missing? I can work on this if the plan is to use idb.
Any updates here? I noticed my review request is still pending. To reiterate, I'd r+ if these were conditionally included, until we have a better solution.
Comment on attachment 629387 [details] [diff] [review] patch What the hell. We'll notice that something is broken if we don't find a better solution before attempting JSConf update.
Attachment #629387 -
Flags: review?(jones.chris.g) → review+
Reporter | ||
Comment 9•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec910f35ce86
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ec910f35ce86
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•