Closed
Bug 760757
Opened 12 years ago
Closed 12 years ago
de-ns-ify nsHTMLSelectAccessible
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: surkov, Assigned: capella)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
35.96 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #630197 -
Flags: review?(surkov.alexander)
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 630197 [details] [diff] [review] Patch (v1) Review of attachment 630197 [details] [diff] [review]: ----------------------------------------------------------------- ::: accessible/src/generic/DocAccessible.cpp @@ +15,5 @@ > #include "Role.h" > #include "RootAccessible.h" > #include "States.h" > > +#include "HTMLSelectAccessible.h" is it needed? ::: accessible/src/generic/RootAccessible.cpp @@ +20,5 @@ > #include "States.h" > > #include "mozilla/dom/Element.h" > + > +#include "HTMLSelectAccessible.h" not needed? ::: accessible/src/html/nsHTMLSelectAccessible.cpp @@ +312,5 @@ > else > HyperTextAccessibleWrap::GetBoundsRect(aTotalBounds, aBoundingFrame); > } > > /** select us! close combo box if necessary*/ pls remove the comment while you are here @@ +647,1 @@ > DocAccessible* aDoc) : wrong indentation
Attachment #630197 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Push to TRY: https://tbpl.mozilla.org/?tree=Try&rev=72c0bc34ea7f
Assignee | ||
Comment 4•12 years ago
|
||
Push to Inbound: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=2bcb94039789
Target Milestone: --- → mozilla16
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6eb0a03905fa
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•