Closed Bug 760796 Opened 12 years ago Closed 12 years ago

Intermittent browser_responsiveui.js | preset 2 or 7: dimension valid (width or height) - Got X, expected Y

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 15

People

(Reporter: past, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 1 obsolete file)

just disable transitions
7.46 KB, patch
paul
: review+
Details | Diff | Splinter Review 
Rev4 MacOSX Snow Leopard 10.6 fx-team debug test mochitest-other on 2012-06-02 03:56:28 PDT for push c9b7a566ff05

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/responsivedesign/test/browser_responsiveui.js | preset 2: dimension valid (width) - Got 555, expected 360
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/responsivedesign/test/browser_responsiveui.js | preset 2: dimension valid (height) - Got 823, expected 640

https://tbpl.mozilla.org/php/getParsedLog.php?id=12305683&tree=Fx-Team
Summary: Intermittent browser_responsiveui.js | preset 2: dimension valid (width) - Got 555, expected 360 | preset 2: dimension valid (height) - Got 823, expected 640 → Intermittent browser_responsiveui.js | preset 2 or 7: dimension valid (width or height) - Got X, expected Y
Attached file Use transition events. (obsolete) — 
If you use timeouts to wait for transitions, you're gonna have a bad time.

This patch adds a ResponsiveUI:Transition event that is fired on the stack after the responsiveUI is done animating.

A simpler fix would just be to always disable transitions during the tests.  Thoughts?
Attachment #629482 - Flags: review?(paul)
(In reply to Dave Camp (:dcamp) from comment #2)
> A simpler fix would just be to always disable transitions during the tests. 
> Thoughts?

Isn't that what we do in the Style Editor?

        Attachment #629482 -
        Attachment is obsolete: true

        Attachment #629482 -
        Flags: review?(paul)

        Attachment #629485 -
        Flags: review?

    
  

        Attachment #629485 -
        Flags: review? → review?(paul)

    
  

        Attachment #629485 -
        Flags: review?(paul) → review+

    
    

    
      
  

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/0a061846efd7
Whiteboard: [orange] → [orange][fixed-in-fx-team]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/0a061846efd7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 15

    
    

    
      
  

    
    

    
  
This is not fixed, it happened to me on a try push containing the patch in comment 7: https://tbpl.mozilla.org/php/getParsedLog.php?id=12365543&tree=Try&full=1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
(In reply to Ehsan Akhgari [:ehsan] from comment #9)
> This is not fixed, it happened to me on a try push containing the patch in
> comment 7:
> https://tbpl.mozilla.org/php/getParsedLog.php?id=12365543&tree=Try&full=1

Ignore me, please!
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [fixed-in-fx-team]

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: