Closed Bug 760905 Opened 12 years ago Closed 12 years ago

Intermittent test_storage_queue.js | test failed Error: Queue is empty

Categories

(Web Apps Graveyard :: AppsInTheCloud, defect)

Product:
Web Apps Graveyard
Component:
AppsInTheCloud
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: anant, Assigned: gps)

References

Details

(Keywords: intermittent-failure, Whiteboard: [blocking-aitc+][qa-])

Attachments

(1 file)

Change bounds to prevent equivalence
1.09 KB, patch
rnewman
: review+
Details | Diff | Splinter Review 
The xpcshell test for AITC's storage-registry seems to be failing in a few environemnts. I've noticed 2 failures so far, one in Linux 64 opt (https://tbpl.mozilla.org/php/getParsedLog.php?id=12323978&tree=Services-Central#error0) and the other in OS 64 debug (https://tbpl.mozilla.org/php/getParsedLog.php?id=12323859&tree=Services-Central)

Investigate. Not sure if it's a 64 bit specific issue, or just an intermittent bug with an as-yet-unknown case. My hunch is that it might have something to do with the async write.
I temporarily commented out this test because of intermittent oranges. I deemed this acceptable because the feature being tested is not enabled by default and leaving the test active would just burden people who watch the trees.

https://hg.mozilla.org/services/services-central/rev/a0b10aaad563
Whiteboard: [fixed in services][leave open]
https://hg.mozilla.org/mozilla-central/rev/a0b10aaad563
Whiteboard: [fixed in services][leave open] → [leave open]
Whiteboard: [leave open] → [leave open] [blocking-aitc]
Whiteboard: [leave open] [blocking-aitc] → [leave open] [blocking-aitc+]
OS: Linux → All
Hardware: x86 → All
Bug 760896 (where this test was enabled again) landed and tbpl looks promising: https://tbpl.mozilla.org/?tree=Services-Central&rev=5099eb0d0287

We'll wait for a few more runs, but I suspect this has been fixed.
Ok, bug 760896 merged to m-c, and there have been several pushes to m-i with no oranges for this test. Closing, we can re-open if we find an orange later on.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [leave open] [blocking-aitc+] → [blocking-aitc+]
Whiteboard: [blocking-aitc+] → [blocking-aitc+], [qa-]
(In reply to Anant Narayanan [:anant] from comment #4)
> Ok, bug 760896 merged to m-c, and there have been several pushes to m-i with
> no oranges for this test. Closing, we can re-open if we find an orange later
> on.

Bug 760896 only recently landed in m-c. If you look at services-central, there were oranges after this patch landed. I think we still have this issue.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [blocking-aitc+], [qa-] → [blocking-aitc+][qa-][orangefactor]
Feel free to punt to mconnor.
Assignee: nobody → gps
Status: REOPENED → ASSIGNED
Attachment #641117 - Flags: review?(rnewman)
Comment on attachment 641117 [details] [diff] [review]
Change bounds to prevent equivalence

Review of attachment 641117 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/aitc/tests/unit/test_storage_queue.js
@@ +53,5 @@
>    let items = [{test:"object"}, "teststring", 42];
>  
>    // Two random numbers: how many items to queue and how many to remove.
> +  let num = Math.floor(Math.random() * 100 + 20);
> +  let rem = Math.floor(Math.random() * 15 + 5);

Can we add an explanatory assertion or comment here that rem < num, and that we're doing it to avoid emptying the queue?
Attachment #641117 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/425a2086db6d

Included new comment and additional do_check tests for bounds sanity. Pushed to inbound so this orange can hopefully disappear sooner.
https://hg.mozilla.org/mozilla-central/rev/425a2086db6d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Blocks: 438871
Whiteboard: [blocking-aitc+][qa-][orangefactor] → [blocking-aitc+][qa-][orange]
Whiteboard: [blocking-aitc+][qa-][orange] → [blocking-aitc+][qa-]
Product: Web Apps → Web Apps Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: