Closed
Bug 760970
Opened 12 years ago
Closed 12 years ago
Custom menu button hard to press after recent redesign
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox15 fixed)
VERIFIED
FIXED
Firefox 16
Tracking | Status | |
---|---|---|
firefox15 | --- | fixed |
People
(Reporter: micmon, Assigned: sriram)
References
Details
Attachments
(5 files)
54.58 KB,
image/png
|
Details | |
50.38 KB,
image/png
|
Details | |
6.85 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
20.11 KB,
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
21.94 KB,
image/png
|
Details |
In recent builds featuring the redesigned UI, the menu button moved to the left of the new tab button and is very hard to press now. The touch target should be larger. Also, the target seems to be only on the left side of the button right now, as pressing on the middle/right activates the new tab button.
Comment 1•12 years ago
|
||
Agreed, running into this too on my Galaxy Nexus (Android 4.0.4). Sriram?
tracking-fennec: --- → ?
status-firefox15:
--- → affected
OS: Linux → Android
Summary: Menu button hard to press after redesign → Custom menu button hard to press after recent redesign
Comment 2•12 years ago
|
||
Attached is a screenshot with visible touch feedback enabled on Android 4.0.4 - the target sampled in the zone in the screenshot is overlaid over the menu button but triggers the 'new tab' button.
Comment 3•12 years ago
|
||
More obvious with button-down highlight ...
Assignee | ||
Comment 4•12 years ago
|
||
The width is 36dp on portrait mode. This should be 48dp to match the height of the action bar. Also, it should on top of the tabs-button (with a transparent background), to avoid accidental touches being delivered to tabs button (especially when hitting the curve).
Updated•12 years ago
|
Assignee: nobody → sriram
Updated•12 years ago
|
status-firefox16:
--- → affected
Version: Firefox 15 → Firefox 16
Assignee | ||
Comment 7•12 years ago
|
||
This patch resizes the menu button to be square, and places it on top of the tabs button. The touch goes to menu button and not to tabs.
Attachment #631272 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 8•12 years ago
|
||
This patch optimizes the orange color used. I felt we are using way too many orange highlight, even though they don't come with a texture. The other problem is they are not scalable. I'll attach a screenshot with differences soon.
Attachment #631274 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 9•12 years ago
|
||
This shows the difference between the two. Basically they both don't have any difference. Ian's resource has a 1pixel yellow color on the top, that merges with the background's top 1px inside glow color. Given the fact that this is going to be "under" the finger, and not going to be visible to the user much when he press, I guess we can use a gradient and kill 15 resources in the name of https://areweslimyet.com/
Updated•12 years ago
|
Attachment #631272 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
Attachment #631274 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 10•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/b79284be046a http://hg.mozilla.org/integration/mozilla-inbound/rev/c4b6f8f04f9a
Comment 11•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b79284be046a https://hg.mozilla.org/mozilla-central/rev/c4b6f8f04f9a (Merged by Ed Morley)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment 12•12 years ago
|
||
I know this is resolved already, but I just wanted to add that I am happy to see a gradient selection applied in code rather than with a bunch of different images. I too am a fan of efficiency. Sometimes. :)
Updated•12 years ago
|
status-firefox16:
affected → ---
Comment 13•12 years ago
|
||
Verified fixed on Nightly 16.0a1 (2012-06-12) Samsung Galaxy SII (2.3.4)
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 14•12 years ago
|
||
Comment on attachment 631272 [details] [diff] [review] Patch (1/2): Menu button resize [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Soft Menu button will be hard to press on Nexus. Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String or UUID changes made by this patch:
Attachment #631272 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 15•12 years ago
|
||
Comment on attachment 631274 [details] [diff] [review] Patch (2/2): Optimize the orange color [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: More resources will be used unnecessarily. Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String or UUID changes made by this patch:
Attachment #631274 -
Flags: approval-mozilla-aurora?
Comment 16•12 years ago
|
||
Comment on attachment 631272 [details] [diff] [review] Patch (1/2): Menu button resize [Triage Comment] Little risk this early in the cycle.
Attachment #631272 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•12 years ago
|
Attachment #631274 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 17•12 years ago
|
||
Pushed to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/adebfe601696 https://hg.mozilla.org/releases/mozilla-aurora/rev/c15196a7217b
Updated•12 years ago
|
Version: Firefox 16 → Firefox 15
Updated•11 years ago
|
tracking-fennec: ? → ---
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•