Closed
Bug 760971
Opened 12 years ago
Closed 12 years ago
Port |Bug 728141 - Replace old synchronous favicons calls in browser| to Thunderbird
Categories
(Thunderbird :: Toolbars and Tabs, defect)
Thunderbird
Toolbars and Tabs
Tracking
(thunderbird14 fixed, thunderbird15 fixed)
RESOLVED
FIXED
Thunderbird 16.0
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
mconley
:
review+
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
References: Bug 713642 - (asyncFaviconCallers) Replace all old synchronous favicons calls in the codebase. Bug 713269 - Use Asynchronous Favicons API for PlacesUtils.jsm. Bug 728141 - Replace old synchronous favicons calls in browser.
Attachment #629590 -
Flags: review?(mconley)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 629590 [details] [diff] [review] Switch to Asynchronous Favicons [Checked in: Comment 2 & 4] Review of attachment 629590 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks.
Attachment #629590 -
Flags: review?(mconley) → review+
Comment on attachment 629590 [details] [diff] [review] Switch to Asynchronous Favicons [Checked in: Comment 2 & 4] http://hg.mozilla.org/comm-central/rev/f6e3760f12cc
Attachment #629590 -
Attachment description: Switch to Asynchronous Favicons → Switch to Asynchronous Favicons [Checked in: Comment 2]
Comment on attachment 629590 [details] [diff] [review] Switch to Asynchronous Favicons [Checked in: Comment 2 & 4] [Approval Request Comment] Regression caused by (bug #): User impact if declined: Favicon may not be correct for any browser pages, so probably not very visible. Testing completed (on c-c, etc.): c-c Risk to taking this patch (and alternatives if risky): Low risk, ported patch landed on Firefox 13.
Attachment #629590 -
Flags: approval-comm-beta?
Attachment #629590 -
Flags: approval-comm-aurora?
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
|
||
Updated•12 years ago
|
Attachment #629590 -
Flags: approval-comm-beta?
Attachment #629590 -
Flags: approval-comm-beta+
Attachment #629590 -
Flags: approval-comm-aurora?
Attachment #629590 -
Flags: approval-comm-aurora+
|
|
||
Comment 4•12 years ago
|
||
Checked in: https://hg.mozilla.org/releases/comm-aurora/rev/6573c4a21686 https://hg.mozilla.org/releases/comm-beta/rev/709068332aaf
status-thunderbird14:
--- → fixed
status-thunderbird15:
--- → fixed
Attachment #629590 -
Attachment description: Switch to Asynchronous Favicons [Checked in: Comment 2] → Switch to Asynchronous Favicons [Checked in: Comment 2 & 4]
You need to log in
before you can comment on or make changes to this bug.
Description
•