76114 - leaks in nsJSInstallTriggerGlobal.cpp

Status: RESOLVED WORKSFORME

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In nsJSInstallTriggerGlobal.cpp there are 3 occurrences of the line:

nsCOMPtr<nsIScriptGlobalObject> globalObject = scriptContext->GetGlobalObject();

which is an automatic leak and should probably be replaced by

nsCOMPtr<nsIScriptGlobalObject>
globalObject(dont_AddRef(scriptContext->GetGlobalObject()));

See bug 76091 for a similar problem.

Comment 1

[Daniel Veditz [:dveditz]]

Hmm, looks like a common problem. If this is the case then aren't all the 
"nsIScriptGlobalObject *global = aContext->GetGlobalObject()" places leaks 
also? More leaks than not shown by

http://lxr.mozilla.org/seamonkey/search?string=-%3EGetGlobalObject

Comment 2

[Daniel Veditz [:dveditz]]

On closer inspection many of those spots do a manual release, but there are 
still several other nsCOMPtr<> uses.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The only other ones that look like leaks were the ones in nsCrypto.cpp (which is
now obsolete, I think) and in oji (lcglue.cpp and nsCSecurityContext.cpp).  I
filed bug 76144 on the OJI ones, and I'll hope psm-glue will just go away.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Remove the code is one way to fix the bug.