Closed
Bug 761212
Opened 12 years ago
Closed 12 years ago
Custom menu should scroll to top whenever it is shown
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox15 verified, firefox16 verified, firefox17 verified)
VERIFIED
FIXED
Firefox 16
People
(Reporter: sriram, Assigned: sriram)
Details
Attachments
(1 file)
1.65 KB,
patch
|
mfinkle
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Custom menu should scroll to top whenever it is shown. Currently only the visibility is changed for the menu.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → sriram
OS: Mac OS X → Android
Hardware: x86 → ARM
Assignee | ||
Comment 1•12 years ago
|
||
This patch makes sure that the custom menu scrolls to top, whenever it is opened. openOptionsMenu() gets called for non-h/w menu button devices. onMenuOpened() gets called for h/w menu button devices.
Attachment #629872 -
Flags: review?(mark.finkle)
Comment 2•12 years ago
|
||
Comment on attachment 629872 [details] [diff] [review] Patch ask for aurora approval too
Attachment #629872 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 3•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/e7f9c105f6a2
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e7f9c105f6a2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Assignee | ||
Comment 5•12 years ago
|
||
Comment on attachment 629872 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): - User impact if declined: Custom menu will stay at the same position where it was left earlier. This is different from stock android's behavior. Testing completed (on m-c, etc.): 06/06 Risk to taking this patch (and alternatives if risky): None. String or UUID changes made by this patch: -
Attachment #629872 -
Flags: approval-mozilla-aurora?
Comment 6•12 years ago
|
||
Comment on attachment 629872 [details] [diff] [review] Patch [Triage Comment] No risk, go for it.
Attachment #629872 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 7•12 years ago
|
||
Pushed to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/c22bed811ceb
Updated•12 years ago
|
status-firefox15:
--- → fixed
Updated•12 years ago
|
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•