761278 - Remove XHR.onuploadprogress

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Tracking this to make sure we remove again in the next migration (or evaluate needing to apply the patch from 743666)

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Assigning to bz for now - is there work to be done here now that 15 is on the Beta channel?

Comment 3

[Boris Zbarsky [:bzbarsky]]

I don't think we need to track this for 15.

Basically, this bug is about removing a nonstandard feature that we've had for a while.  Firefox 14 shipped with a deprecation warning for uses of this feature.  The only question is how long we wait to remove it...

Looking at the addons mxr, I see three uses of onuploadprogress:

 /8482/content/dropioApiClient.js 
 /10550/chrome/content/ajaxUpload.js 
 /14651/chrome/content/ajaxUpload.js 

We should probably at least get those fixed before we remove it.

Comment 4

[Jorge Villalobos [:jorgev] (he/him)]

We can add it to the compatibility validations for whatever version this ships on, so it isn't necessary to wait for these add-ons to be fixed. We will warn them as long as a I know on which version this is happening.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Jorge, thanks!

Peter, any objections to removing this in 17?

Comment 6

[Peter Van der Beken [:peterv]]

Fine by me.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: No more uploadprogress

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 644562 [details] [diff] [review]
No more uploadprogress

Review of attachment 644562 [details] [diff] [review]:
-----------------------------------------------------------------

Yay!

Comment 9

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ef14686c31d0

Comment 10

[Jason Duell]

Backed out due to bustage

 https://hg.mozilla.org/integration/mozilla-inbound/rev/ad5866c81a03

see

 https://tbpl.mozilla.org/php/getParsedLog.php?id=13747517&tree=Mozilla-Inbound#error0

for errors

Comment 11

[Boris Zbarsky [:bzbarsky]]

As far as I can tell, this just triggered a rebuild of the generated events stuff somehow and _that_ just failed for whatever reason.  And is continuing to fail even with this patch backed out, since this patch had nothing to do with it to start with...

Comment 12

[Boris Zbarsky [:bzbarsky]]

Relanded as http://hg.mozilla.org/integration/mozilla-inbound/rev/8fe7b1000a26

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8fe7b1000a26

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

untracking for 15 as per comment 3

Comment 15

[Saurabh Nair [:jsx] (not reading bugmail. ni? if you need me)]

Clearing dev-doc-needed since I didn't think any change was needed in the current XHR doc.

Comment 16

[Saurabh Nair [:jsx] (not reading bugmail. ni? if you need me)]

Apologies for triggering multiple bugmails.

Updated dev doc: https://developer.mozilla.org/en-US/Firefox/Releases/17