Closed
Bug 761299
Opened 12 years ago
Closed 12 years ago
Cleanup DeleteRangeTxn::CreateTxnsToDeleteBetween
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
3.62 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #629903 -
Flags: review?(ehsan)
Comment 1•12 years ago
|
||
Comment on attachment 629903 [details] [diff] [review] Patch v1 Review of attachment 629903 [details] [diff] [review]: ----------------------------------------------------------------- ::: editor/libeditor/base/DeleteRangeTxn.cpp @@ +268,2 @@ > > + child = child->GetNextSibling(); Please loop on |child|, not the child count.
Attachment #629903 -
Flags: review?(ehsan) → review-
Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 629903 [details] [diff] [review] Patch v1 Review of attachment 629903 [details] [diff] [review]: ----------------------------------------------------------------- ::: editor/libeditor/base/DeleteRangeTxn.cpp @@ +253,5 @@ > + } > + > + nsCOMPtr<nsINode> startParent = do_QueryInterface(aStartParent); > + NS_ENSURE_STATE(startParent); > + NS_ASSERTION(aEndOffset <= startParent->Length(), "bad aEndOffset"); This should actually be GetChildCount() (which doesn't make any difference)
Comment 3•12 years ago
|
||
Comment on attachment 629903 [details] [diff] [review] Patch v1 Review of attachment 629903 [details] [diff] [review]: ----------------------------------------------------------------- ::: editor/libeditor/base/DeleteRangeTxn.cpp @@ +253,5 @@ > + } > + > + nsCOMPtr<nsINode> startParent = do_QueryInterface(aStartParent); > + NS_ENSURE_STATE(startParent); > + NS_ASSERTION(aEndOffset <= startParent->Length(), "bad aEndOffset"); Right. @@ +268,2 @@ > > + child = child->GetNextSibling(); NM.
Attachment #629903 -
Flags: review- → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/42c17eb4789a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•