761438 - B2G filesystem permissions

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Guillaume Destuynder [:kang] [this account is no longer active]]

Hopefully this is the right component (and not github) for this one bug.

It seems gecko is creating a few directories with a wide open umask, unless those are chmoded for any reason (resulting in 0777 or 0666 file/dirs)

List:

/data/b2g/mozilla/2n2g4pgx.default/.parentlock
/data/b2g/mozilla/2n2g4pgx.default/startupCache
/data/b2g/mozilla/2n2g4pgx.default/localstore.rdf
/data/b2g/mozilla/profiles.ini
/cache/Cache

The last one is the most important but ideally all of them should be created with a sensible umask (at least, 022 which results into 0644 files, or rw-r--r--), or if they do need 777 for directories, with the sticky t bit set (restricted deletion, i.e. like /tmp).

If those files are created elsewhere, and belong to another component, I couldn't find it, but please let me know :)

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We need to fix our umask, or buggy content processes will be able to hose files on the fs that they shouldn't be able to see at all.

Comment 2

[Guillaume Destuynder [:kang] [this account is no longer active]]

See https://github.com/mozilla-b2g/gonk-misc/pull/27

note that this does not fix pushing stuff via adb during gaia install if adb has umask 000
gaia should probably be written as an image instead

Comment 3

[Guillaume Destuynder [:kang] [this account is no longer active]]

pull request has been accepted