Closed Bug 761531 Opened 12 years ago Closed 12 years ago

FileIOObject should add mError in CC

Categories

(Core Graveyard :: File Handling, defect)

Product:
Core Graveyard
Component:
File Handling
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: mounir, Assigned: mounir)

Details

Attachments

(1 file)

Patch
1.44 KB, patch
smaug
: review+
mounir
: checkin+
Details | Diff | Splinter Review 
It is missing from:
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED and NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED and I believe it should be added here as:
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_NSCOMPTR(mError) and NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mError)
Attached patch Patch — — Splinter Review 
Assignee: nobody → mounir
Status: NEW → ASSIGNED

        Attachment #630119 -
        Flags: review?(bugs)

    
    

    
  
Comment on attachment 630119 [details] [diff] [review]
Patch

In practice this shouldn't matter atm, since DOMError shouldn't keep anything
alive. But this is future-proof. Once DOMError starts to use new bindings,
it may keep stuff alive.

        Attachment #630119 -
        Flags: review?(bugs) → review+

    
  
Flags: in-testsuite-
Target Milestone: --- → mozilla16

    
  

        Attachment #630119 -
        Flags: checkin+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/4f99c2d9741e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: