761717 - Right Indent button looks like the Left Indent button in the Compose window

Status: VERIFIED FIXED

(Thunderbird :: Theme, defect)

Description

[u279076]

Attachment: Screenshot

See screenshot. Reproducible in Thunderbird 12.0.1 (Ubuntu bundled), 13.0 (official), and 16.0a1 Nightly.

Comment 1

[:aceman]

Bwinton, Andreas, any idea where do these icons come from? I could not see them in the format-buttons.png of gnomestripe theme. But i qute (windows) the icons for indentation are in that file. Do they come from the system (gnome) theme on linux?

Comment 2

[Richard Marti (:Paenglab)]

Could this be a Linux icon theme problem I'm not seeing wizh my Linux icon theme? This icons are coming from GTK

http://hg.mozilla.org/comm-central/file/e622ef230d64/mail/themes/gnomestripe/mail/compose/messengercompose.css#l398
and
http://hg.mozilla.org/comm-central/file/e622ef230d64/mail/themes/gnomestripe/mail/compose/messengercompose.css#l405

Comment 3

[Richard Marti (:Paenglab)]

Anthony, do you still see this behavior?

Comment 4

[u279076]

(In reply to Richard Marti [:paenglab] from comment #3)
> Anthony, do you still see this behavior?

Yes. Ubuntu 12.04 64-bit, Thunderbird Daily 17.0a1 2012-08-11.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: patch

Anthony, you're right. I have now a totally unpatched Ubuntu 12.04 and can see your problem. My old Ubuntu always showed the icons correct with gtk-unindent-ltr and gtk-unindent-rtl. Now with unindent and intent it works on both Ubuntus.

Andreas, I hope you have a non-Ubuntu system to check if the icons are still working.

Comment 6

[Andreas Nilsson (:andreasn)]

I didn't see any regressions on Fedora 17 (also GTK+ 3.4), so we should be good. Going to look into the deeper cause a bit, but it works for us regardless it seems.

Comment 7

[Andreas Nilsson (:andreasn)]

Comment on attachment 651499 [details] [diff] [review]
patch

Also worked well when I tried the Force RTL, so I think we're good.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/e6254541c435

Comment 9

[u279076]

Verified fixed with Thunderbird 17.0a1 2012-08-21.