Closed
Bug 761857
Opened 12 years ago
Closed 12 years ago
Make MOZ_CRASH() stop debuggers on the line containing it (or MOZ_ASSERT) on Linux, not in abort()
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
1.75 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
With this change, I can't explain why the #elif defined(__APPLE__) bit is needed, since it's identical to the #else. Is there some reason I shouldn't common up the two? (I'm going to put the mozalloc_abort change we discussed in a separate bug, FYI.)
Attachment #630368 -
Flags: review?(ted.mielczarek)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 630368 [details] [diff] [review] Patch Review of attachment 630368 [details] [diff] [review]: ----------------------------------------------------------------- Definitely merge the common cases.
Attachment #630368 -
Flags: review?(ted.mielczarek) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca61695732aa
Target Milestone: --- → mozilla16
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ca61695732aa
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•