Closed
Bug 761890
Opened 12 years ago
Closed 12 years ago
[Skia] Fix Skia bugs which prevent Azure canvas tests from passing
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: nrc, Assigned: nrc)
References
Details
Attachments
(5 files, 2 obsolete files)
5.57 KB,
patch
|
nrc
:
review+
|
Details | Diff | Splinter Review |
9.07 KB,
patch
|
nrc
:
review+
|
Details | Diff | Splinter Review |
241.50 KB,
patch
|
gw280
:
review+
|
Details | Diff | Splinter Review |
7.56 KB,
patch
|
nrc
:
review+
|
Details | Diff | Splinter Review |
12.62 KB,
patch
|
nrc
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #630439 -
Flags: review?(gwright)
Assignee | ||
Comment 2•12 years ago
|
||
Moved from Bug 746883 and rebased. Carrying r=gw280
Attachment #630442 -
Flags: review+
Assignee | ||
Comment 3•12 years ago
|
||
Moved from Bug 746883 and rebased carrying r=gw280
Attachment #630443 -
Flags: review+
Comment 4•12 years ago
|
||
Comment on attachment 630439 [details] [diff] [review] patch 1: build Skia under Windows Review of attachment 630439 [details] [diff] [review]: ----------------------------------------------------------------- Looks good otherwise, please run it through try first for all platforms. ::: gfx/skia/update.sh @@ +50,5 @@ > cp $1/src/ports/*.cpp ./src/ports/ > cp $1/src/svg/*.cpp ./src/svg/ > cp $1/src/svg/*.h ./src/svg/ > +cp $1/src/sfnt/*.cpp ./src/svg/ > +cp $1/src/sfnt/*.h ./src/svg/ Need to update the target directory here
Attachment #630439 -
Flags: review?(gwright) → review-
Assignee | ||
Comment 5•12 years ago
|
||
Fixed. Running on Try right now.
Attachment #630439 -
Attachment is obsolete: true
Attachment #630448 -
Flags: review?(gwright)
Assignee | ||
Comment 6•12 years ago
|
||
Try push (builds): https://tbpl.mozilla.org/?tree=Try&rev=5ff61477b1a4
Updated•12 years ago
|
Attachment #630448 -
Flags: review?(gwright) → review+
Assignee | ||
Comment 7•12 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=173cfa8a92ad
Assignee | ||
Comment 8•12 years ago
|
||
moved from Bug 746883, guarded with azureSkia rather than making pass, carrying r=gw280,jmuizelaar
Attachment #631195 -
Flags: review+
Assignee | ||
Comment 9•12 years ago
|
||
Moved from bug 746883, carrying r=ggw280,jmuizelaar
Attachment #631196 -
Flags: review+
Assignee | ||
Comment 10•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=88c6ee3a9aef
Target Milestone: --- → mozilla16
Comment 11•12 years ago
|
||
Sorry, I had to back this out on inbound because of a reftest.list syntax error and a leak in debug reftests: https://hg.mozilla.org/integration/mozilla-inbound/rev/253d5996845e
Target Milestone: mozilla16 → ---
Comment 12•12 years ago
|
||
> #fails with Skia due to Skia bug 568
This confuses my after-fix tool. I'd prefer a hyperlink into their bug tracker.
Assignee | ||
Comment 13•12 years ago
|
||
(In reply to Jesse Ruderman from comment #12) > > #fails with Skia due to Skia bug 568 > > This confuses my after-fix tool. I'd prefer a hyperlink into their bug > tracker. http://code.google.com/p/skia/issues/detail?id=568
Assignee | ||
Comment 14•12 years ago
|
||
Another Try push: https://tbpl.mozilla.org/?tree=Try&rev=5b27bac1b664
Target Milestone: --- → mozilla16
Assignee | ||
Comment 15•12 years ago
|
||
Added a hyperlink in a comment for Jesse (comment 11), carrying r=gw280,jmuizelaar
Attachment #631196 -
Attachment is obsolete: true
Attachment #633009 -
Flags: review+
Assignee | ||
Updated•12 years ago
|
Target Milestone: mozilla16 → ---
Assignee | ||
Comment 16•12 years ago
|
||
Trying again to land: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8c1c326ed100
Target Milestone: --- → mozilla16
Comment 17•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a24de192b216 https://hg.mozilla.org/mozilla-central/rev/c2539605ff49 https://hg.mozilla.org/mozilla-central/rev/856142f34511 https://hg.mozilla.org/mozilla-central/rev/e3af4396672d https://hg.mozilla.org/mozilla-central/rev/8c1c326ed100
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•