761952 - Thunderbird 13 Attachment Window "add" button for attachment services is cut-off

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: cut off button

see screenshot the add "hinzufuegen" button is cut off

Comment 1

[Carsten Book [:Tomcat]]

or better its a text overflow :)

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

mconley: This looks fine on Windows XP. Can you provide more space for the buttons? Eight characters for the label is a very small limit, in my humble opinion.

Comment 3

[Andreas Nilsson (:andreasn)]

Attachment: patch to fix the issue

This removes the flex from the #provider-listing xul, and that seems to do the trick. I added the width to #cloudFileView instead so that we avoid getting screwed by really long provider labels. Unfortunately I could not get text-overflow: ellipsis; working, so really long labels gets cut straight off.

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: screenshot of patch in action

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 631433 [details] [diff] [review]
patch to fix the issue

Review of attachment 631433 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 6

[Mark Banner (:standard8)]

Checked in:

https://hg.mozilla.org/comm-central/rev/64605d5789cc

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 631433 [details] [diff] [review]
patch to fix the issue

[Triage Comment]
I think we should also take this on 13.0.1 as it is a new feature.

Comment 8

[Mark Banner (:standard8)]

Checked in:

https://hg.mozilla.org/releases/comm-aurora/rev/03db7bf5a05a
https://hg.mozilla.org/releases/comm-beta/rev/42e16affd853

Comment 9

[Mark Banner (:standard8)]

Fixed for 13.0.1:

https://hg.mozilla.org/releases/comm-release/rev/fec9149ec534