Closed Bug 762044 Opened 12 years ago Closed 12 years ago

Move content/html/content/test/test_bug660238.html into content/html/content/tests/forms/

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch
1.68 KB, patch
Ms2ger
: review+
mounir
: checkin+
Details | Diff | Splinter Review
Attached patch Patch (obsolete) — — Splinter Review 
      No description provided.
Attachment #630562 - Flags: review?(Ms2ger)
Attached patch Patch — — Splinter Review 
That might be better ;)
Attachment #630562 - Attachment is obsolete: true
Attachment #630562 - Flags: review?(Ms2ger)
Attachment #630563 - Flags: review?(Ms2ger)
Comment on attachment 630563 [details] [diff] [review]
Patch

Review of attachment 630563 [details] [diff] [review]:
-----------------------------------------------------------------

While you're here....

var errorString = "foo";
if (!expectedResult) {
  errorString = "bar";
}

should be

var errorString = expectedResult
                  ? "foo"
                  : bar;

and

for each(var test in tests) {

should be

for (var test of tests) {

r=me with those things fixed.
Attachment #630563 - Flags: review?(Ms2ger) → review+
Flags: in-testsuite-
Target Milestone: --- → mozilla16
Attachment #630563 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/89e71d2ea54d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: