Closed Bug 762047 Opened 12 years ago Closed 12 years ago

Improve content/html/content/tests/forms/test_progress_element.html

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
Some changes in bug 686913 weren't the best actually.
Attachment #630564 - Flags: review?(Ms2ger)
Comment on attachment 630564 [details] [diff] [review]
Patch

Review of attachment 630564 [details] [diff] [review]:
-----------------------------------------------------------------

Sure
Attachment #630564 - Flags: review?(Ms2ger) → review+
Depends on: 762435
Attached patch Patch v2Splinter Review
Trivial change: the element is now labelable.
Attachment #630564 - Attachment is obsolete: true
Attachment #630923 - Flags: review?(Ms2ger)
Comment on attachment 630923 [details] [diff] [review]
Patch v2

Review of attachment 630923 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the description fixed.

::: content/html/content/test/forms/test_progress_element.html
@@ +222,5 @@
> +  var label = document.createElement('label');
> +
> +  content.appendChild(label);
> +  label.appendChild(aElement);
> +  is(label.control, aElement, "progress should not be labelable");

not?
Attachment #630923 - Flags: review?(Ms2ger) → review+
Flags: in-testsuite+
Target Milestone: --- → mozilla16
Attachment #630923 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/113a75e9bf67
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: