Closed
Bug 762135
Opened 12 years ago
Closed 12 years ago
Syntax error from <script src=""> on every page
Categories
(Marketplace Graveyard :: Admin Tools, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: krupa.mozbugs, Unassigned)
References
()
Details
steps to reproduce: 1. Load https://marketplace-dev.allizom.org/en-US/account-lookup/ 2. Search for user ID: 5540398 expected behavior: Information associated with that ID shows up or there is an informative error message. actual behavior: We show an error message- "Oops! not allowed" I see this in my error console: Timestamp: 6/6/12 10:39:01 AM Error: SyntaxError: syntax error Source File: https://marketplace-dev.allizom.org/en-US/account-lookup/ Line: 1 Source Code: <!DOCTYPE html>
Comment 1•12 years ago
|
||
This happens on every page: https://github.com/mozilla/zamboni/blob/master/mkt/templates/base.html#L34
Summary: Syntax error on entering user ID during Account Lookup → Syntax error from <script src=""> on every page
Updated•12 years ago
|
Priority: -- → P1
Comment 2•12 years ago
|
||
This fixes the csrf issue, but if you submit the form "too soon", it just doesn't do anything. This is preferrable to a 403, but still. https://github.com/mozilla/zamboni/commit/3687a20
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 3•12 years ago
|
||
(In reply to Potch [:potch] from comment #2) > This fixes the csrf issue, but if you submit the form "too soon", it just > doesn't do anything. This is preferrable to a 403, but still. > > https://github.com/mozilla/zamboni/commit/3687a20 I think this was meant for bug 762281?
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
Comment 4•12 years ago
|
||
the csrf fixed krupa's filed bug, didn't see the changed summary.
Comment 5•12 years ago
|
||
removed the empty script tag, so this no longer occurs.
Status: UNCONFIRMED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Comment 6•12 years ago
|
||
Verified as fixed in https://marketplace-dev.allizom.org/lookup/ on FF20 (Win 7) Postfix screencast http://screencast.com/t/fB0Ic1ljU4m Closing bug.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•