762206 - Use nsScriptErrorEvent when firing error events on window objects

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

We fire a plain Event at them now, but that doesn't unwrap properly when hitting window.onerror. The fix is to use nsScriptErrorEvent.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 637147 [details] [diff] [review]
Patch

Review of attachment 637147 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that fixed

::: dom/indexedDB/IDBObjectStore.cpp
@@ +1464,5 @@
>    if (!IsWriteAllowed()) {
>      return NS_ERROR_DOM_INDEXEDDB_READ_ONLY_ERR;
>    }
>  
> +  nsRefPtr<IDBRequest> request = GenerateRequest(this, nsnull);

Why null here?

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Because that function is only called in the parent process when doing IPC indexedDB, so there's no script information to get.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Bent explained why things work the way they do. Nothing to see here, move along. r+ stands.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/939191463ed4