762258 - Don't show duplicate information in Account lookup

Status: VERIFIED FIXED

(Marketplace Graveyard :: Admin Tools, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/en-US/account-lookup/5540398/summary
2. Notice the 'Addresses' section

expected behavior:
We only show the latest address for the user OR at least show only distinct address information.

actual behavior:
We list a lot of duplicate information. See screenshot

Comment 1

[Kumar McMillan [:kumar]]

The data model is a little weird because we capture payment info per addon not per developer. I can change it to filter out dupes though (and look a little prettier).

Comment 2

[Kumar McMillan [:kumar]]

The issue is that the template loops over developer addresses but does not check for duplicates. This can be fixed in the view before getting passed to the template:
https://github.com/mozilla/zamboni/blob/master/mkt/lookup/views.py#L54
https://github.com/mozilla/zamboni/blob/master/mkt/lookup/templates/lookup/user_summary.html#L71

Comment 3

[Wraithan (Chris McDonald) [:wraithan]]

andym suggests we leave this until we figure out payments. Most cases AddonPaymentData is going away or changing so we can deal with it then.

Here is the code I've written so far with some review comments:

https://github.com/wraithan/zamboni/commit/3ccea8c

Comment 4

[Wraithan (Chris McDonald) [:wraithan]]

https://github.com/mozilla/zamboni/commit/28935b8

Will show addresses that differ at all.

Comment 5

[krupa raj[:krupa]]

verified at https://marketplace-dev.allizom.org/lookup/user/5540398/summary

Comment 6

[krupa raj[:krupa]]

Attachment: verified fixed