Closed Bug 76228 Opened 23 years ago Closed 23 years ago

background color in cell tab shouldn't get checked on cancel

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.1

People

(Reporter: Brade, Assigned: cmanske)

Details

(Whiteboard: FIX IN HAND)

Attachments

(2 files)

fixes enable states for rowcount=1 and colcount=1 cases
1.79 KB, patch
Details | Diff | Splinter Review
The correct fix: Move setting checkbox until after test for Cancel key
732 bytes, patch
Details | Diff | Splinter Review 
In the table dialog, in the cell tab, if I click on the color picker and then
click on the cancel button, the checkbox gets checked even though I haven't
changed anything.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.1
Fix is ready for review
Keywords: patch, review
Whiteboard: FIX IN HAND need r=, sr=
Ignore patch! Wrong bug.
Keywords: patch, review
Whiteboard: FIX IN HAND need r=, sr=
Last patch is correct fix.
Keywords: patch, review
Whiteboard: FIX IN HAND need r=, sr=
looks good; r=brade
Whiteboard: FIX IN HAND need r=, sr= → FIX IN HAND need sr=
Removing "need sr"
Whiteboard: FIX IN HAND need sr= → FIX IN HAND
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
checked in
verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: