Closed
Bug 762366
Opened 12 years ago
Closed 12 years ago
Refactor omx plugin's ReadVideo method
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: cajbir, Assigned: cajbir)
References
Details
Attachments
(1 file)
|
3.92 KB,
patch
|
eflores
:
review+
|
Details | Diff | Splinter Review |
The ReadVideo method of OMXPlugin uses an infinite 'for' loop with conditionals to break or continue. This makes the control flow hard to follow and should be refactored so the infinite loop is not needed.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → chris.double
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #631217 -
Flags: review?(eflores)
Attachment #631217 -
Flags: review?(eflores) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Needs bug 761762 landed first, waiting for that to be ready before checkin-needed on this.
Depends on: 761762
|
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fd06ff2ed50
Target Milestone: --- → mozilla16
|
||
Updated•12 years ago
|
Whiteboard: [inbound]
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2fd06ff2ed50 (Merged by Ed Morley)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•12 years ago
|
Whiteboard: [inbound]
You need to log in
before you can comment on or make changes to this bug.
Description
•