Closed
Bug 762389
Opened 12 years ago
Closed 12 years ago
de-ns-ify nsXULTreeAccessible and nsXULTreeGridAccessible
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: surkov, Assigned: capella)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
111.61 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #631202 -
Flags: review?(surkov.alexander)
Reporter | ||
Comment 2•12 years ago
|
||
Comment on attachment 631202 [details] [diff] [review] Patch (v1) Review of attachment 631202 [details] [diff] [review]: ----------------------------------------------------------------- r=me, thank you! ::: accessible/src/base/nsAccUtils.h @@ +26,5 @@ > class HyperTextAccessible; > class DocAccessible; > struct nsRoleMapEntry; > #ifdef MOZ_XUL > +class XULTreeAccessible; shouldn't it be namespaced? ::: accessible/src/generic/RootAccessible.cpp @@ +54,3 @@ > #include "nsIXULDocument.h" > #include "nsIXULWindow.h" > +#include "XULTreeAccessible.h" nit: you'd need to keep it with other accessible class files ::: accessible/src/msaa/Makefile.in @@ +42,5 @@ > ia2AccessibleHypertext.cpp \ > ia2AccessibleRelation.cpp \ > RootAccessibleWrap.cpp \ > TextLeafAccessibleWrap.cpp \ > + XULTreeGridAccessibleWrap.cpp \ shouldn't it be ifdefed by MOZ_XUL? (see src/Makefile.in) ::: accessible/src/msaa/nsXULTreeGridAccessibleWrap.cpp @@ +34,5 @@ > + DocAccessible* aDoc, > + XULTreeGridRowAccessible* aRowAcc, > + nsITreeBoxObject* aTree, > + nsITreeView* aTreeView, > + PRInt32 aRow, nsITreeColumn* aColumn) : wrong indent ::: accessible/src/xul/nsXULTreeAccessible.cpp @@ +1073,5 @@ > } > > void > +XULTreeItemAccessibleBase::GetCellName(nsITreeColumn* aColumn, > + nsAString& aName) on the same line please @@ +1181,4 @@ > > void > +XULTreeItemAccessible::RowInvalidated(PRInt32 aStartColIdx, > + PRInt32 aEndColIdx) on the same line please ::: accessible/src/xul/nsXULTreeGridAccessible.cpp @@ +398,5 @@ > } > > NS_IMETHODIMP > +XULTreeGridAccessible::IsColumnSelected(PRInt32 aColumnIndex, > + bool* aIsSelected) on same line please
Attachment #631202 -
Flags: review?(surkov.alexander) → review+
Assignee | ||
Comment 3•12 years ago
|
||
FYI ReL:
::: accessible/src/base/nsAccUtils.h
@@ +26,5 @@
> class HyperTextAccessible;
> class DocAccessible;
> struct nsRoleMapEntry;
> #ifdef MOZ_XUL
> +class XULTreeAccessible;
I forgot (again) to HG Refresh the Queue before posting ... the last thing I had to do to get the build working was remove the whole #ifdef / class XULTreefoo / #endif set of lines ... It caused an ambiguous reference error in nsaccessibilityservice.cpp ...
Assignee | ||
Comment 4•12 years ago
|
||
Here's the patch with comments 2 / 3 addressed ... let me know if the makefile.in tweak looks ok?
Attachment #631202 -
Attachment is obsolete: true
Reporter | ||
Comment 5•12 years ago
|
||
yes, thank you
Assignee | ||
Comment 6•12 years ago
|
||
Inbound TRY puss ... https://tbpl.mozilla.org/?tree=Try&rev=783d249232b3
Assignee | ||
Comment 7•12 years ago
|
||
inbound push https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8d547fb468e7
Target Milestone: --- → mozilla16
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8d547fb468e7
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•