762396 - replace do_QueryObject() with static cast in CAccessibleEditableText

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Trevor Saunders (:tbsaunde)]

similar to bug 762394

Comment 1

[Andrew Quartey [:drexler]]

Attachment: patch

passed all tests locally.

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 633201 [details] [diff] [review]
patch

> #include "HyperTextAccessible.h"
>+#include "HyperTextAccessibleWrap.h"

the second neccessarily includes the first, so only include the second.

> CAccessibleEditableText::copyText(long aStartOffset, long aEndOffset)
> {
> __try {
>-  nsRefPtr<HyperTextAccessible> textAcc(do_QueryObject(this));
>-  if (textAcc->IsDefunct())
>+  HyperTextAccessible* ia2AccessibleText = static_cast<HyperTextAccessibleWrap*>(this);

uh, I meant rename the class, not the variables, so CAccessibleEditableText is what should be changed to ia2AccessibleEditableText


otherwise seems fine.

Comment 3

[Andrew Quartey [:drexler]]

Attachment: patch

Updated patch addressing comments.

Comment 4

[Trevor Saunders (:tbsaunde)]

Comment on attachment 633351 [details] [diff] [review]
patch

>+ia2AccessibleEditableText::copyText(long aStartOffset, long aEndOffset)

nit, same issue here and below were you break alignment.

Comment 5

[Andrew Quartey [:drexler]]

Attachment: updated_patch

Updated patch addressing nits.

Comment 6

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/25ca50ce8653

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/25ca50ce8653