762434 - Allow any element to be labelable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 630919 [details] [diff] [review]
Patch

GetFirstDescendantFormControl should probably be renamed to GetFirstLabelableDescendant.

r=me with that.

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/fab542b4877f

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 630919 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: bug fixed by bug 762435 will stay around for 3 months
Risk to taking this patch (and alternatives if risky): this patch alone is pretty safe, it is only moving some logic from a class to another.
String or UUID changes made by this patch: mozilla::dom::Element UUID change

Comment 4

[Alex Keybl [:akeybl]]

(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #3)
> String or UUID changes made by this patch: mozilla::dom::Element UUID change

We typically do not take UUID changes unless we're very confident that there will be no add-on compat or web compat breakage. Can you confirm?

Comment 5

[Boris Zbarsky [:bzbarsky]]

There should be no web compat issues from the IID change.

Addons are tougher, but QueryInterface to Element _should_ be pretty rare.  It's a reasonably new class and most ways of getting one do not involve QueryInterface.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 630919 [details] [diff] [review]
Patch

Thanks bz, approving in that case.

Comment 7

[Mounir Lamouri (:mounir)]

Pushed in aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/0e385bd36e31