Closed
Bug 762519
Opened 12 years ago
Closed 12 years ago
Send xpconnect stack dump and javascript dump output to OutputDebugString
Categories
(Core :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: jimm, Assigned: jimm)
References
Details
Attachments
(2 files, 1 obsolete file)
606 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
7.04 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
I'd like to add a simple build config option that enables routing debug output to the Windows local/remote debugger via OutputDebugString. Something like "--enable-win-debug". I'm particularly interested seeing dump() and XPCDebug output, although maybe there's a way to capture everything we normally dump to the win console and send it over.
Assignee | ||
Comment 1•12 years ago
|
||
http://hg.mozilla.org/projects/elm/rev/d850e7827a2a doh!
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #1) > http://hg.mozilla.org/projects/elm/rev/d850e7827a2a > > doh! oops, wrong bug. double doh!
Assignee | ||
Comment 3•12 years ago
|
||
Assignee: nobody → jmathies
Assignee | ||
Comment 4•12 years ago
|
||
Assignee | ||
Comment 5•12 years ago
|
||
use printf instead of puts in DebugDump.
Attachment #642903 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #642907 -
Flags: review?(mrbkap)
Assignee | ||
Updated•12 years ago
|
Attachment #642902 -
Flags: review?(ehsan)
Updated•12 years ago
|
Attachment #642902 -
Flags: review?(ehsan) → review+
Comment 6•12 years ago
|
||
Comment on attachment 642907 [details] [diff] [review] XPCDebug patch Review of attachment 642907 [details] [diff] [review]: ----------------------------------------------------------------- Nits only. ::: js/xpconnect/src/XPCDebug.cpp @@ +277,5 @@ > { > char* buf; > JSExceptionState *state = JS_SaveExceptionState(cx); > if (!state) > + DebugDump("Call to a debug function modifying state!\n"); It'd be slightly faster and less error-prone to make this: DebugDump("%s", "...") and below, also. Failing that, it'd be a decent idea to use the gcc warning flags to get some error coverage for bad uses. @@ +406,1 @@ > (void *)obj, js::GetObjectClass(obj)->name); Nit: re-indent the second line.
Attachment #642907 -
Flags: review?(mrbkap) → review+
Assignee | ||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a85081e2fbff
Assignee | ||
Updated•12 years ago
|
Summary: Add build option for sending console debug output to OutputDebugString → Send xpconnect stack dump and javascript dump output to OutputDebugString
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a85081e2fbff
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Comment 10•12 years ago
|
||
Comment on attachment 642902 [details] [diff] [review] js dump patch >@@ -4558,16 +4558,21 @@ nsGlobalWindow::Dump(const nsAString& aStr) >+ OutputDebugStringA(cstr); Nit: I would have preferred OutputDebugStringW(PromiseFlatString(aStr).get());
Comment 11•12 years ago
|
||
Comment on attachment 642907 [details] [diff] [review] XPCDebug patch >+ char buffer[2048]; DumpJSStack can try to dump more than 2048 characters, unfortunately. >+ printf(buffer); printf(buffer); is potentially unsafe; use fputs(stdout, buffer); or printf("%s", buffer); >- fputs(buf, stdout); >+ DebugDump("%s\n", buf); Confusingly, although puts adds a newline, fputs does not.
Updated•10 years ago
|
OS: Windows 8 Metro → Windows 8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•