Closed
Bug 762531
Opened 12 years ago
Closed 12 years ago
[shipping] update defaults for multi-locale json
Categories
(Webtools Graveyard :: Elmo, defect)
Webtools Graveyard
Elmo
Tracking
(Not tracked)
RESOLVED
FIXED
2.2
People
(Reporter: Pike, Assigned: mozilla)
Details
Attachments
(1 file)
1.43 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
The defaults for mobile are awful, let's update them to repo being releases/mozilla-beta, platform being android,android-xul, multi being android-multilocale, and path being mobile/android/locales/maemo-locales. Those are in https://github.com/mozilla/elmo/blob/develop/apps/shipping/templates/shipping/confirm-ship.html
Assignee | ||
Comment 1•12 years ago
|
||
The default platform should be just 'android', as we aren't building single locale repacks for android-xul.
Assignee | ||
Comment 2•12 years ago
|
||
If you strongly prefer a pull request I can do that.
Attachment #632759 -
Flags: review?(l10n)
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 632759 [details] [diff] [review] elmo diff Review of attachment 632759 [details] [diff] [review]: ----------------------------------------------------------------- Actually, we work with patches in bugzilla for most of our stuff. I'm still a gecko guy, not a webdev :-) Thanks for the patch, I'll land that tomorrow.
Attachment #632759 -
Flags: review?(l10n) → review+
Comment 4•12 years ago
|
||
Commit pushed to develop at https://github.com/mozilla/elmo https://github.com/mozilla/elmo/commit/576fb4c9a61f6060c8e00c4dcb103e0d2f835c2f bug 762531, update defaults for mobile l10n-changesets.json, r=Pike
Reporter | ||
Comment 5•12 years ago
|
||
Marking FIXED. This should go into production next monday, in time for the next go-to-build.
Assignee: nobody → aki
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2
Reporter | ||
Comment 6•12 years ago
|
||
That's in production now, too.
Updated•4 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•